Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make bidderInfo endpoint case insensitive #3136

Merged
merged 1 commit into from
Sep 26, 2023
Merged

make bidderInfo endpoint case insensitive #3136

merged 1 commit into from
Sep 26, 2023

Conversation

gargcreation1992
Copy link
Contributor

@gargcreation1992 gargcreation1992 commented Sep 25, 2023 •
edited by onkarvhanumante
Loading

This PR makes /info/bidders/:bidderName endpoint as case insensitive. Now, we will be able to make the call to this endpoint using /info/bidders/APPNEXUS for example.
There is special all case that is also handled in this PR.

partially resolves #2400

@onkarvhanumante onkarvhanumante self-assigned this Sep 25, 2023
@Sonali-More-Xandr Sonali-More-Xandr self-assigned this Sep 25, 2023
@onkarvhanumante onkarvhanumante merged commit 63170b8 into master Sep 26, 2023
3 checks passed
@bsardo bsardo removed the PBS 2.0 label Sep 26, 2023
@SyntaxNode SyntaxNode deleted the PBS-1258 branch October 2, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sonali-More-Xandr Sonali-More-Xandr Sonali-More-Xandr approved these changes

@onkarvhanumante onkarvhanumante onkarvhanumante approved these changes

Assignees

@onkarvhanumante onkarvhanumante

@Sonali-More-Xandr Sonali-More-Xandr

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bidder names should be case insensitive
4 participants
@gargcreation1992 @onkarvhanumante @Sonali-More-Xandr @bsardo